Skip to content

fix: correctly return resumed notes #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

kptkin
Copy link
Collaborator

@kptkin kptkin commented Apr 18, 2025

Description

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.unreleased.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.35%. Comparing base (fca2300) to head (d98de02).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
core/internal/runbranch/resume.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9739      +/-   ##
==========================================
- Coverage   80.39%   80.35%   -0.05%     
==========================================
  Files         781      781              
  Lines       81264    81274      +10     
==========================================
- Hits        65335    65306      -29     
- Misses      15199    15241      +42     
+ Partials      730      727       -3     
Flag Coverage Δ
func 46.10% <9.09%> (-0.02%) ⬇️
system 64.84% <72.72%> (+0.01%) ⬆️
unit 65.07% <18.18%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/internal/runbranch/state.go 100.00% <100.00%> (ø)
core/internal/stream/sender.go 69.86% <100.00%> (+0.25%) ⬆️
core/internal/runbranch/resume.go 87.34% <25.00%> (-1.70%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kptkin kptkin force-pushed the kpt/fix-resume-notes branch from b8d730f to d98de02 Compare April 18, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant